[#210] Fix writer dashboard: dedupe donations, fix royalty display#212
[#210] Fix writer dashboard: dedupe donations, fix royalty display#212realproject7 merged 2 commits intomainfrom
Conversation
- WriterTradingStats: removed duplicate Donations column (now 2-col: Token Price + TVL only) - ClaimRoyalties: use formatTruncated with 10 digits for tiny amounts (never shows "0" when nonzero), green text when unclaimed > 0, claim button inline-adjacent to royalty amount Fixes #210 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
- Deduplication — Donations column removed from WriterTradingStats, grid changed to 2-col. Clean.
- formatTruncated — Smart nonzero guard: if truncation produces "0" but value > 0, keeps full precision. 10-digit default appropriate for royalties.
- Green text — Conditional
text-accentwhen unclaimed > 0. Good visual cue. - Inline button — Claim button moved adjacent to amount with
ml-2. Better layout.
Net -24 lines. No issues.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
This fixes the duplicate donations and tiny-royalty formatting issues, but it does not fully address the royalties placement problem from issue #210. The royalties UI is still rendered as a separate block below the stats section instead of being integrated into that stats area.
Findings
- [medium] Royalties remain outside the stats area, so the placement fix is incomplete.
- File:
src/app/dashboard/writer/page.tsx:129 - Suggestion: Adjust the card layout so the royalties row is part of the stats section rather than a separate sibling rendered after
WriterTradingStats. That is the missing part of the issue's layout requirement.
- File:
Decision
Requesting changes because issue #210 explicitly calls for royalties to be integrated into the bottom-left stats area, and this PR leaves ClaimRoyalties as a separate block below WriterTradingStats.
Wrap WriterTradingStats + ClaimRoyalties in a single container with consistent spacing. Remove individual mt-3 margins. ClaimRoyalties now visually part of the stats section. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up commit resolves the remaining layout gap from issue #210 by grouping WriterTradingStats and ClaimRoyalties into the same stats section and removing the extra top margin that previously left royalties visually detached. The duplicate donations, tiny-amount formatting, green positive-state styling, and adjacent claim button behavior are all in place.
Findings
- [info] Previous blocking finding resolved.
- File:
src/app/dashboard/writer/page.tsx:142 - Suggestion: None.
- File:
Decision
Approving because the royalties row is now visually integrated into the stats area as requested, GitHub lint-and-typecheck is passing, and local typecheck is clean.
2 participants
Summary
formatTruncatedwith 10 decimal digits — never shows "0" when actual value is nonzero.text-accentwhen > 0.Fixes #210
Test plan
tsc --noEmit— zero errorsnext build— fails due to DNS/Google Fonts (not code issue)🤖 Generated with Claude Code